-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix setting ROI #86
Merged
aliddell
merged 9 commits into
acquire-project:main
from
nclack:85-setting-an-roi-is-broken
Aug 15, 2023
Merged
Fix setting ROI #86
aliddell
merged 9 commits into
acquire-project:main
from
nclack:85-setting-an-roi-is-broken
Aug 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nclack
commented
Aug 14, 2023
nclack
commented
Aug 14, 2023
nclack
changed the title
set shape before offset to avoid offset oob error
Fix setting ROI
Aug 14, 2023
andy-sweet
approved these changes
Aug 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, other than the CHANGELOG comment.
nclack
commented
Aug 14, 2023
aliddell
approved these changes
Aug 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #85
adds test, updates changelog
Changes the ROI setting procedure so it's more robust:
Sometimes the offset has to be divisible by 4. When setting a parameter that is not appropriately divisible, the call just fails with an invalid parameter which is not very helpful.
Fortunately, when running in "progressive" mode (the default for light-sheet), there are fewer restrictions. I'm not exactly sure how to query the restrictions, so the approach for this PR is to make sure we're setting the mode early.