Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort the entries in Hacktoberfest_Inputt.xlsx #11

Open
achoudh5 opened this issue Oct 3, 2020 · 6 comments
Open

Sort the entries in Hacktoberfest_Inputt.xlsx #11

achoudh5 opened this issue Oct 3, 2020 · 6 comments

Comments

@achoudh5
Copy link
Owner

achoudh5 commented Oct 3, 2020

  • The entries in the Hacktoberfest_Inputt.xlsx file can be duplicate in certain rows, I would like to sort the rows based on either source or destination column (column D and F). if the same entries/cell values appear in rows then they should be one after another.

For ex.
Let's say in row 3->cell value is 1.2.3.4 and then in row 45 again the cell value is 1.2.3.4. In this situation, i would like to see row 45 below row 3 ie at row 4 and shift the rows from 4 down one position.

@Ishita-Mehta
Copy link

Hi! I would like to contribute for this issue. Hope it is okay if I use pandas library for the same. Have a good day!

P.S. Hacktoberfest released an update for maintainers hope this repo is complying to it https://hacktoberfest.digitalocean.com/hacktoberfest-update

@Ishita-Mehta
Copy link

Hi @achoudh5 Please add hacktoberfest to the topics of the repo as currently the PR is not being counted by digital ocean. These new rules are mentioned in the link in my previous comment. Thanks a lot!

@achoudh5
Copy link
Owner Author

achoudh5 commented Oct 3, 2020

Thank you @Ishita-Mehta for notifying, as far as I saw it says label issue with hacktoberfest and put hacktoberfest-accepted once PR gets approved right? Please suggest if there is anything I am missing, I want each one of contributors to get the credit of their work!

@achoudh5
Copy link
Owner Author

achoudh5 commented Oct 3, 2020

Hi! I would like to contribute for this issue. Hope it is okay if I use pandas library for the same. Have a good day!

P.S. Hacktoberfest released an update for maintainers hope this repo is complying to it https://hacktoberfest.digitalocean.com/hacktoberfest-update

Yes, pandas is very welcome as well. Make sure you fetch and pull the repo as it's always work in progress :)

@Ishita-Mehta
Copy link

Thank you @Ishita-Mehta for notifying, as far as I saw it says label issue with hacktoberfest and put hacktoberfest-accepted once PR gets approved right? Please suggest if there is anything I am missing, I want each one of contributors to get the credit of their work!

Hey, you need to add hacktoberfest as a topic for the repo as well. Below is what is mentioned in the update:

_'''We will honor all valid pull requests prior to this change, and as of October 3, 2020 at 12:00:00 UTC – and October 3 in all time zones – pull requests will only count toward earning a T-shirt or planting a tree if they are submitted in a repository classified with the ‘hacktoberfest’ topic. The pull requests will also need to be merged, approved by a maintainer, or labeled as ‘hacktoberfest-accepted’ in order to qualify. The deadline for completions, merging, labeling, and approving is November 1.

To put it in terms that folks will more easily understand:

PRs count if:
Submitted in a repo with the hacktoberfest topic AND
during the month of October AND (
The PR is merged OR
The PR is labelled as hacktoberfest-accepted by a maintainer OR
The PR has been approved

)'''_

@achoudh5
Copy link
Owner Author

achoudh5 commented Oct 3, 2020

Thank you @Ishita-Mehta for notifying, as far as I saw it says label issue with hacktoberfest and put hacktoberfest-accepted once PR gets approved right? Please suggest if there is anything I am missing, I want each one of contributors to get the credit of their work!

Hey, you need to add hacktoberfest as a topic for the repo as well. Below is what is mentioned in the update:

_'''We will honor all valid pull requests prior to this change, and as of October 3, 2020 at 12:00:00 UTC – and October 3 in all time zones – pull requests will only count toward earning a T-shirt or planting a tree if they are submitted in a repository classified with the ‘hacktoberfest’ topic. The pull requests will also need to be merged, approved by a maintainer, or labeled as ‘hacktoberfest-accepted’ in order to qualify. The deadline for completions, merging, labeling, and approving is November 1.

To put it in terms that folks will more easily understand:

PRs count if:
Submitted in a repo with the hacktoberfest topic AND during the month of October AND ( The PR is merged OR The PR is labelled as hacktoberfest-accepted by a maintainer OR The PR has been approved
)'''_

Just did and updated readme to thank you! Thank you so much :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants