[score_instrument] use getInstanceData to get the instrument data #9263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The score_instrument script breaks with JSON data. This updates the script to use getInstanceData() instead of trying to write an SQL query directly so that it works no matter what format the instrument saves data in.
driusan
force-pushed
the
FixScoreInstrumentJSONData
branch
from
afd70cb
to
1009142
Compare
CamilleBeau
approved these changes
May 16, 2024
CamilleBeau
added
the
Passed Manual Tests
maximemulder
pushed a commit
to maximemulder/Loris
that referenced
this pull request
Sep 25, 2024
…es#9263) The score_instrument script breaks with JSON data. This updates the script to use getInstanceData() instead of trying to write an SQL query directly so that it works no matter what format the instrument saves data in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The score_instrument script breaks with JSON data. This updates the script to use getInstanceData() instead of trying to write an SQL query directly so that it works no matter what format the instrument saves data in.