Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find a better way to edit templates #2

Open
molenzwiebel opened this issue Nov 10, 2016 · 0 comments
Open

Find a better way to edit templates #2

molenzwiebel opened this issue Nov 10, 2016 · 0 comments

Comments

@molenzwiebel
Copy link
Member

Relevant comments in template-content.ts: https://github.com/ace-lol/Ace/blob/master/src/hook-providers/template-content.ts#L10-L13.

Currently, we wrap HTMLTemplateElement.content and give plugins the opportunity to do their initialization/changes there. However, the scope of the hook is fairly big, even if plugins behave and unregister their hook after applying their changes. Ideally, I would like to edit the HTML after insertion, but that gives a whole other range of problems/things to consider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant