MG-163 - Add snap to grid effect on layout #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixgateru
force-pushed
the
MG-163-snap_to_grid
branch
2 times, most recently
from
d1c78be
to
0250027
Compare
ianmuchyri
requested changes
Feb 27, 2024
ui/web/templates/dashboard.html
Outdated
| @@ -14,6 +14,9 @@ | |||
| crossorigin="anonymous" | |||
| referrerpolicy="no-referrer" | |||
| ></script> | |||
| <link rel="stylesheet" href="//code.jquery.com/ui/1.12.1/themes/base/jquery-ui.css" /> | |||
| <script src="//code.jquery.com/jquery-3.6.0.min.js"></script> | |||
| <script src="//code.jquery.com/ui/1.12.1/jquery-ui.min.js"></script> | |||
There was a problem hiding this comment.
where is this jquery being used?
remove unused importations
felixgateru
force-pushed
the
MG-163-snap_to_grid
branch
4 times, most recently
from
8c071a6
to
754197d
Compare
dborovcanin
force-pushed
the
MG-163-snap_to_grid
branch
from
754197d
to
ac17bd9
Compare
felixgateru
force-pushed
the
MG-163-snap_to_grid
branch
2 times, most recently
from
afbba48
to
4766bab
Compare
felixgateru
force-pushed
the
MG-163-snap_to_grid
branch
2 times, most recently
from
19ba86c
to
a08e0ab
Compare
dborovcanin
requested changes
Mar 7, 2024
ui/web/static/js/dashboard.js
Outdated
| grid.refreshItems(); | ||
| grid.layout(true); | ||
| document.removeEventListener("mouseup", finalizeResize); | ||
| console.log("Resize finalized"); |
ui/web/templates/dashboard.html
Outdated
| @@ -14,6 +14,7 @@ | |||
| crossorigin="anonymous" | |||
| referrerpolicy="no-referrer" | |||
| ></script> | |||
| <link rel="stylesheet" href="//code.jquery.com/ui/1.12.1/themes/base/jquery-ui.css" /> | |||
There was a problem hiding this comment.
It was used in a previous implementation with jquery but has now been removed.
felixgateru
force-pushed
the
MG-163-snap_to_grid
branch
from
a08e0ab
to
d74ddf4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #175 +/- ##
=======================================
Coverage ? 76.74%
=======================================
Files ? 3
Lines ? 215
Branches ? 0
=======================================
Hits ? 165
Misses ? 34
Partials ? 16 ☔ View full report in Codecov by Sentry. |
felixgateru
force-pushed
the
MG-163-snap_to_grid
branch
2 times, most recently
from
7b4b05a
to
d4d8211
Compare
|
some charts are not snapping to the grid: |
dborovcanin
force-pushed
the
MG-163-snap_to_grid
branch
from
6d41b8d
to
66068c0
Compare
|
@1998-felix there is a scroll bar that appears at the bottom that is not required: |
Signed-off-by: felix.gateru <felix.gateru@gmail.com>
Signed-off-by: felix.gateru <felix.gateru@gmail.com>
Signed-off-by: felix.gateru <felix.gateru@gmail.com>
Signed-off-by: felix.gateru <felix.gateru@gmail.com>
Signed-off-by: felix.gateru <felix.gateru@gmail.com>
Signed-off-by: felix.gateru <felix.gateru@gmail.com>
Signed-off-by: felix.gateru <felix.gateru@gmail.com>
Signed-off-by: 1998-felix <felix.gateru@gmail.com>
Signed-off-by: 1998-felix <felix.gateru@gmail.com>
Signed-off-by: 1998-felix <felix.gateru@gmail.com>
Signed-off-by: 1998-felix <felix.gateru@gmail.com>
felixgateru
force-pushed
the
MG-163-snap_to_grid
branch
from
66068c0
to
f9ce97b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this do?
Adds snap to grid effect on the layout.
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
Did you document any new/modified functionality?
Notes