Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make webhooks more resilient #2516

Closed
wants to merge 1 commit into from
Closed

Make webhooks more resilient #2516

wants to merge 1 commit into from

Commits on Oct 17, 2023

  1. Make webhooks more resilient 

    * Do not quit on subscription API errors. Instead, wait a configurable interval before retrying.
* Shorten default webhook expiration and renewal intervals to reduce the chance of http 409 errors.
* Handle http 409 on subscription creation by taking over the existing subscription.
* Handle http 404 on subscription renewal by creating a new subscription(current behavior, listed for completeness).
* Log other known http errors include 400 (bad webhook endpoint), 401 (auth failed), and 403 (too many subscriptions).
* Log detailed messages when encoutering unknown http errors to assist with future debugging.
    @Lyncredible
    Lyncredible committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    30ee83a View commit details
    Browse the repository at this point in the history