Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add support for reference_type" #1517

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Revert "Add support for reference_type" #1517

merged 1 commit into from
Jul 22, 2024

Conversation

TG1999
Copy link
Contributor

@TG1999 TG1999 commented Jul 22, 2024

Reverts #1502

@TG1999
Copy link
Contributor Author

TG1999 commented Jul 22, 2024

@ziadhany I am reverting #1502 , please check it once and re-open it tests are failing

@TG1999 TG1999 merged commit 6727786 into main Jul 22, 2024
10 of 11 checks passed
@ziadhany
Copy link
Collaborator

@TG1999 the issue was in the cargo test and I fixed on EPSS #1481

@TG1999
Copy link
Contributor Author

TG1999 commented Jul 22, 2024

Gotcha! can you please open the PR again for #1502

TG1999 added a commit that referenced this pull request Jul 22, 2024
ziadhany pushed a commit that referenced this pull request Aug 1, 2024
This reverts commit 6727786.

Signed-off-by: ziadhany <ziadhany2016@gmail.com>
TG1999 added a commit that referenced this pull request Aug 6, 2024
* Revert "Revert "Add support for reference_type (#1502)" (#1517)"

This reverts commit 6727786.

Signed-off-by: ziadhany <ziadhany2016@gmail.com>

* Fix cargo test

Signed-off-by: ziadhany <ziadhany2016@gmail.com>

* Fix test by adding reference_type to ordering list

Signed-off-by: ziadhany <ziadhany2016@gmail.com>

* Regen apache_kafka test fixture

Signed-off-by: Keshav Priyadarshi <git@keshav.space>

---------

Signed-off-by: ziadhany <ziadhany2016@gmail.com>
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
Co-authored-by: ziadhany <ziadhany2016@gmail.com>
Co-authored-by: Keshav Priyadarshi <git@keshav.space>
ziadhany pushed a commit to ziadhany/vulnerablecode that referenced this pull request Aug 6, 2024
…boutcode-org#1517)"

This reverts commit 6727786.

Signed-off-by: ziadhany <ziadhany2016@gmail.com>
ziadhany pushed a commit to ziadhany/vulnerablecode that referenced this pull request Sep 2, 2024
…boutcode-org#1517)"

This reverts commit 6727786.

Signed-off-by: ziadhany <ziadhany2016@gmail.com>
@pombredanne pombredanne deleted the revert-1502-ref-type branch September 24, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants