Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RTD build configuration from skeleton #1337

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Add RTD build configuration from skeleton #1337

merged 1 commit into from
Nov 10, 2023

Conversation

AyanSinhaMahapatra
Copy link
Contributor

@AyanSinhaMahapatra AyanSinhaMahapatra commented Nov 10, 2023 •
edited
Loading

RTD builds were failing as we were not using the build.os field which is required.
This adds the RTD build conf from skeleton to fix the issue.

@AyanSinhaMahapatra
Add RTD build configuration from skeleton
d5f07b3 
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
@TG1999
Copy link
Contributor

TG1999 commented Nov 10, 2023

Thanks++ @AyanSinhaMahapatra

TG1999
TG1999 approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@TG1999 TG1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TG1999 TG1999 merged commit d8cdaf4 into main Nov 10, 2023
11 checks passed
@pombredanne pombredanne deleted the fix-rtd-build branch July 16, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TG1999 TG1999 TG1999 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AyanSinhaMahapatra @TG1999