Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for VC database fields #977

Closed
mjherzog opened this issue Oct 20, 2022 · 13 comments
Closed

Add documentation for VC database fields #977

mjherzog opened this issue Oct 20, 2022 · 13 comments
Assignees
Labels
documentation Everything about documentation

Comments

@mjherzog
Copy link
Member

We need to add Reference documentation for the VulnerableCode database fields. Perhaps we can regenerate the diagrams that @johnmhoran created about a month ago (copies attached). We may need to figure out how to create them in a narrower width format because is it annoying to scroll for this type of diagram - see https://vulnerablecode.readthedocs.io/en/latest/reference_framework_overview.html.
This may be the time to widen our RTD page format.

@mjherzog mjherzog added the documentation Everything about documentation label Oct 20, 2022
@mjherzog
Copy link
Member Author

VC_DB_core_diagram
VC_DB_diagram

@pombredanne
Copy link
Collaborator

As an example we generate models docs in SCIO here https://scancodeio.readthedocs.io/en/latest/data-models.html

@mjherzog
Copy link
Member Author

@johnmhoran We need to widen this page in the RTD as you did for the Audit/Analysis/SPATS RTD. There are already 2 tables there that you cannot read in portrait-only format so we need landscape even before considering how to display a DB diagram. It would be best if you can just widen the page for now since we have not polled the team on changing look & feel overall.

@johnmhoran
Copy link
Contributor

Will do @mjherzog .

@johnmhoran
Copy link
Contributor

@mjherzog I've added some simple CSS and folder structure etc. and the vulnerablecode RTD page now has the wide look of the other RTD. The latter has much more CSS for various widgets, dropdowns, a navbar etc. and I'm not proposing we add all of that to the vulnerablecode RTD. However, before I commit and push I could show you what we now have locally and get any immediate additional feedback you might have. Comparisons pasted below. How would you like to proceed?

Before:

image

After:

image

@mjherzog
Copy link
Member Author

Please proceed with the width change for now. I think that we will want to make landscape and a default and add some or all of the other features from the private RTDs, but we need to engage a broader group who are interested in our doc style. I am guessing Ayan, Dennis, Thomas and Philippe, but we need to open the floor to all nexB people and likely the AboutCode community people who are interested.

@johnmhoran
Copy link
Contributor

OK.

johnmhoran added a commit that referenced this issue Nov 15, 2023
Reference: #977

Note: I just noticed that I named the branch with 997 but the issue is 977.

Signed-off-by: John M. Horan <johnmhoran@gmail.com>
johnmhoran added a commit that referenced this issue Nov 15, 2023
…#977

Reference: #977

Signed-off-by: John M. Horan <johnmhoran@gmail.com>
@johnmhoran
Copy link
Contributor

@mjherzog I've reviewed my 2022 notes, created a new test branch, loaded/installed various packages including graphviz, and my initial simple command produced this -- a start.

test-vcio-db-2023-11-20-01

TG1999 pushed a commit that referenced this issue Nov 21, 2023
* Widen the RTD page #997

Reference: #977

Note: I just noticed that I named the branch with 997 but the issue is 977.

Signed-off-by: John M. Horan <johnmhoran@gmail.com>

* Add width, margin and padding adjustments for mobile displays <= 768px #977

Reference: #977

Signed-off-by: John M. Horan <johnmhoran@gmail.com>

---------

Signed-off-by: John M. Horan <johnmhoran@gmail.com>
@mjherzog
Copy link
Member Author

@johnmhoran Thank you for the diagram! It seems from top-down that there are two major chunks here:

  • The application data which includes everything from left-to-right including Advisory
  • The admin data which includes everything from left-to-right starting with Token Proxy
    So it would be nice to somehow split this into 2 diagrams along those lines.

@johnmhoran
Copy link
Contributor

@mjherzog Here's an example of the application group:

test-vcio-db-application-2023-11-21-01

and the admin group:

test-vcio-db-admin-2023-11-21-01

@mjherzog
Copy link
Member Author

We should add these to the VulnerableCode RTD documentation - presumably a new sub-section in the Reference section.

johnmhoran added a commit that referenced this issue Nov 28, 2023
Reference: #977

Signed-off-by: John M. Horan <johnmhoran@gmail.com>
johnmhoran added a commit that referenced this issue Nov 28, 2023
Reference: #977

Signed-off-by: John M. Horan <johnmhoran@gmail.com>
@johnmhoran
Copy link
Contributor

@mjherzog I've added a new Model Overview page to the vulnerablecode RTD containing the application and admin graph diagrams generated with Graphviz. You can see the initial draft here:

https://vulnerablecode--1350.org.readthedocs.build/en/1350/reference_model_overview.html

TG1999 pushed a commit that referenced this issue Dec 12, 2023
Reference: #977

Signed-off-by: John M. Horan <johnmhoran@gmail.com>
TG1999 pushed a commit that referenced this issue Dec 12, 2023
Reference: #977

Signed-off-by: John M. Horan <johnmhoran@gmail.com>
TG1999 pushed a commit that referenced this issue Dec 12, 2023
* Add graph model diagrams #977

Reference: #977

Signed-off-by: John M. Horan <johnmhoran@gmail.com>

* Add django-extensions to setup.cfg #977

Reference: #977

Signed-off-by: John M. Horan <johnmhoran@gmail.com>

---------

Signed-off-by: John M. Horan <johnmhoran@gmail.com>
@mjherzog
Copy link
Member Author

mjherzog commented Mar 6, 2024

The diagrams look good. We will need a process to keep them in sync with Model changes over time, but closing this Issue because it has been completed.

@mjherzog mjherzog closed this as completed Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Everything about documentation
Projects
None yet
Development

No branches or pull requests

3 participants