Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change label from "Fixed by vulnerabilties" to "Fixes vulnerabilities" #1501

Closed
TG1999 opened this issue Jul 5, 2024 · 9 comments
Closed
Assignees
Labels

Comments

@TG1999
Copy link
Contributor

TG1999 commented Jul 5, 2024

Screenshot from 2024-07-05 21-31-31

@johnmhoran
Copy link
Contributor

@TG1999 There's no description -- please explain the thinking behind the change you suggest. We've changed the names of these columns several times already in the past -- happy to change again if that what the group wants, but I haven't heard from others that that's what they want.

@johnmhoran
Copy link
Contributor

Not sure if this is helpful, but one way to describe the relationship we're trying to name -- from the PURL's viewpoint, the PURL is "affected by" a vuln or "fixes" a vuln; and from the vuln perspective, the vuln "affects" the PURL or is "fixed by" the PURL. 🤔

@mjherzog
Copy link
Member

mjherzog commented Jul 7, 2024

I think that the current parallel "by" construction makes the most sense.

@DennisClark
Copy link

I think that "Fixes vulnerabilities" would be the best solution.

@DennisClark DennisClark changed the title Change label from "Fixed by vulnerabilties" to "Fixing vulnerabilities" Change label from "Fixed by vulnerabilties" to "Fixes vulnerabilities" Jul 9, 2024
@johnmhoran
Copy link
Contributor

@mjherzog @pombredanne When you have the chance, please share your views on the latest suggestion -- "Fixes vulnerabilities".

@mjherzog
Copy link
Member

mjherzog commented Jul 9, 2024

The terminology is very context dependent as explained by @johnmhoran .
So if we are talking about just the Results page context, then changing "Fixed by vulnerabilites" to "Fixes vulnerabilities" make sense.
On the Essentials page that changes to:

  • Vulnerabilities affecting this package
  • Vulnerabilities fixed by this package
    which makes sense in this context

@pombredanne
Copy link
Collaborator

What I see most commonly is "fixed vulnerabilities" from a package point of view, not "fixes vulnerabilities". Juts removing the "by" should be enough

@johnmhoran
Copy link
Contributor

Thanks @pombredanne. I'll make the change you suggest: "Fixed by vulnerabilties" ==> "Fixed vulnerabilities".

@pombredanne
Copy link
Collaborator

Closed and merged in the issue #1520 that tracks changes in the models, API and UI at once

johnmhoran added a commit that referenced this issue Jul 23, 2024
Reference: #1520
Related prior issue: #1501
Updates: #1519
Signed-off-by: John M. Horan <johnmhoran@gmail.com>
michaelehab pushed a commit to michaelehab/vulnerablecode that referenced this issue Aug 3, 2024
…e-org#1520

Reference: aboutcode-org#1520
Related prior issue: aboutcode-org#1501
Updates: aboutcode-org#1519
Signed-off-by: John M. Horan <johnmhoran@gmail.com>
Signed-off-by: Michael Ehab Mikhail <michael.ehab@hotmail.com>
@pombredanne pombredanne added 1-next and removed 9-next labels Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants