Crlf improvement #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
June 10, 2019 13:11
…TP is applied (replacing any \n with \r\n). Up to decision how to test this. Suggest to adjust tests to foresee that \r\n policy will be applied to the data.
|
@chadgates this change is causing errors when receiving a message to mendelson as2, its not able to verify our signed mdn. |
|
@abhishek-ram : MDN should work now. |
|
Okay I have made changes that incorporate these features, closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use policy instead of replace(...). Separate feature branch. To be reviewed/tested. Also BasicTests do fail, as policy HTTP is applied (replacing any \n with \r\n). Needs to be decided how to test this. Suggest to adjust tests to foresee that \r\n policy will be applied to the data.