Update variables in run_post_receive to fit the meaning #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhishek-ram
reviewed
Oct 4, 2022
| @@ -40,8 +40,8 @@ def run_post_receive(message, full_filename): | |||
| variables = { | |||
| "filename": os.path.basename(full_filename), | |||
| "fullfilename": full_filename, | |||
| "sender": message.organization.as2_name, | |||
| "receiver": message.partner.as2_name, | |||
| "sender": message.partner.as2_name, | |||
There was a problem hiding this comment.
should this not also need a test change
There was a problem hiding this comment.
It should be, I will add the test.
Incompatibility between pylama and pyflakes > 2.4.0 klen/pylama#224
abhishek-ram
reviewed
Oct 4, 2022
Codecov ReportBase: 97.44% // Head: 97.44% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #82 +/- ##
=======================================
Coverage 97.44% 97.44%
=======================================
Files 11 11
Lines 587 587
=======================================
Hits 572 572
Misses 15 15
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
abhishek-ram
approved these changes
Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#81