Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[forward compat?] Support Python 3.10 #622

Closed
webknjaz opened this issue Oct 6, 2021 · 5 comments
Closed

[forward compat?] Support Python 3.10 #622

webknjaz opened this issue Oct 6, 2021 · 5 comments
Assignees

Comments

@webknjaz
Copy link
Contributor

webknjaz commented Oct 6, 2021

Describe the bug

I've recently integrated proxy.py into the test suite of aiohttp. Now that we're trying to add Python 3.10 to the CI, the tests that interact with an instance of proxy.py get a TLS handshake timeout.

I haven't looked into it but my guess is that proxy.py may be incompatible with Python 3.10.

To Reproduce

Steps to reproduce the behavior:

  1. Clone aio-libs/aiohttp
  2. Run make vvtest

Expected behavior

It should work.

Version information

  • OS: Ubuntu with Python 3.10 activated
  • Browser: N/A
  • Device: GHA CI/CD
  • proxy.py Version 2.3.1

Additional context

aio-libs/aiohttp#5927

Screenshots

N/A

@webknjaz webknjaz added the Bug Bug report in proxy server label Oct 6, 2021
@abhinavsingh
Copy link
Owner

Thank you @webknjaz for trying it on Python 3.10. I haven't yet got my hands on 3.10. I'll try to jump on it in coming week and see how it goes.

@abhinavsingh
Copy link
Owner

@webknjaz I updated to 3.10 today. All looks good locally, tests are passing and I am able to post this comment (all via proxy.py running on 3.10). I have also added official support for 3.10 in proxy.py CI.

I looked into the linked issue and IIUC tests at your end are seeing ConnectionAbortedError: SSL handshake is taking longer than 60.0 seconds: aborting the connection error. I am unsure if this is linked to proxy.py, but we'll need to investigate deeply to confirm anything.

I'll give make vvtest a try and see if I can find anything useful.

@abhinavsingh abhinavsingh added the Awaiting Response Waiting for more information / response from issue creator label Oct 29, 2021
@webknjaz
Copy link
Contributor Author

Thanks, that should be helpful! I haven't had time to look into that specific error myself but if I'll be able to check it out, I'll report back here too.

@abhinavsingh abhinavsingh added Enhancement and removed Bug Bug report in proxy server Awaiting Response Waiting for more information / response from issue creator labels Oct 31, 2021
@abhinavsingh
Copy link
Owner

@webknjaz Should we look back into it within aiohttp or do we need to get into proxy.py deeper. In general, proxy.py seems to work fine. I am now using it for more than a month on Python 3.10. Wdyt?

@webknjaz
Copy link
Contributor Author

Well, I'll only be able to check it in that CI once you make a release.

Repository owner locked and limited conversation to collaborators Nov 25, 2021

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants