Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TLSInterception] Ability to enable TLS interception on demand #391

Closed
abhinavsingh opened this issue Jul 7, 2020 · 0 comments
Closed
Labels
Good First Issue Issues for new contributors to pick-up

Comments

@abhinavsingh
Copy link
Owner

Is your feature request related to a problem? Please describe.
Currently, when --ca-* flags are provided, TLS interception is enabled for all requests. However, in certain scenarios there can be a need to only enable TLS interception conditionally. E.g. conditionally intercept for content / ad-blocking. See #378 for background.

Describe the solution you'd like
How to expose this feature to plugins is yet to be decided. Some implementation notes:

  1. By default, base plugin method will return True for all requests if --ca-* flag is provided.
  2. Plugin authors can override this method to return True and False conditionally.

Core will then only perform TLS interception if all the plugins in the chain return True. This is likely to have small performance impact as core will need to iterate over all plugins for every requests. This can be resolved by keeping such plugins higher in the plugin chain, so that core can bail out as soon as possible.

Additional context
See #378 for background.

@abhinavsingh abhinavsingh self-assigned this Jul 7, 2020
@abhinavsingh abhinavsingh added the Good First Issue Issues for new contributors to pick-up label Nov 8, 2021
@abhinavsingh abhinavsingh removed their assignment Nov 10, 2021
Repository owner locked and limited conversation to collaborators Nov 25, 2021

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
Good First Issue Issues for new contributors to pick-up
Projects
None yet
Development

No branches or pull requests

1 participant