support for angular 6 & 7 #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ormat with ng-packagr
|
Nice, thanks a lot. I'll review it soon. |
aberezkin
approved these changes
Nov 10, 2018
|
🙌 thanks @UncleDave for doing this! @aberezkin is there anything blocking this PR from merging? Would love to see this library support Angular 7 |
|
@aberezkin It would be so awesome to have angular 7 support for this library! Is there any reason why the PR isn't merged yet? |
aberezkin
pushed a commit
that referenced
this pull request
Jan 26, 2019
* chore: converted project structure to new angular-cli multi-project format with ng-packagr * added new project folder structure * fix: if a request fails before being sent the image preview is not removed * added the rest of the files from development, did a light linting * fixed base href for github pages * fixed package name * fixed inconsistent package naming in the demo * updated travis.yml to use node 8
|
@ChrisBurch @merlijnvl |
|
@aberezkin |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgraded to angular 6 & 7. Demo upgraded to angular 7. As far as I know Angular 6 is not backwards compatible.
Ditched the old project structure and migrated to the new angular-cli multi-project structure with ng-packagr used to build the library.
Moved to HttpClient instead of deprecated Http.
I don't think I've missed anything, but since the whole project structure has changed it's entirely possible.
fixes #206
fixes #203
fixes #170
fixes #169
fixes #156
fixes #143
fixes #111