Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ability to install plugins as part of the action setup #66

Merged
merged 6 commits into from
Dec 29, 2023

Conversation

xSAVIKx
Copy link
Contributor

@xSAVIKx xSAVIKx commented Dec 18, 2023

So starting somewhat time soon Poetry will not install plugins (such as export plugin e.g.) by default. So this PR add ability to install plugins by default and also installs the export plugin for you by default.

As part of the PR I have also updated versions of the GH actions used in workflows.

@xSAVIKx
Copy link
Contributor Author

xSAVIKx commented Dec 19, 2023

@abatilo can you please take a look? It'd be great to have this feature

@abatilo
Copy link
Owner

abatilo commented Dec 19, 2023

This seems reasonable to me!

abatilo
abatilo previously approved these changes Dec 19, 2023
@xSAVIKx
Copy link
Contributor Author

xSAVIKx commented Dec 19, 2023

@abatilo, right, so a particular version of plugin requires a particular version of poetry. This means that we can have this feature, but let user decide if they want to install smth by default. At least that probably is a safer default strategy.

Can you please run the CI once again?

@xSAVIKx xSAVIKx requested a review from abatilo December 19, 2023 14:55
@xSAVIKx
Copy link
Contributor Author

xSAVIKx commented Dec 19, 2023

@abatilo there's a required check configured and the Ubuntu version was updated to 22.04, so the check never passes. Can you please change the check and maybe merge the PR if everything looks OK?

@xSAVIKx
Copy link
Contributor Author

xSAVIKx commented Dec 21, 2023

@abatilo, sorry to bother but as I mentioned in the previous comment, while the Ubuntu has changed to v22.04 the required check you have right now will be never triggered and thus there's no way to proceed with merging the PR.

It would be great if you can reconfigure the check or force-merge the PR

@abatilo
Copy link
Owner

abatilo commented Dec 29, 2023

Sorry for the delay @xSAVIKx, I had gone on holiday. I'm happy with a force merge!

@abatilo abatilo merged commit a5643c6 into abatilo:master Dec 29, 2023
74 checks passed
Copy link

🎉 This PR is included in version 2.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@xSAVIKx xSAVIKx deleted the feat/add-plugin-installations branch January 23, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants