Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merging dev/gfdl latest with ML_diffusivity #4

Merged
merged 4 commits into from
Aug 29, 2024
Merged

Commits on Aug 20, 2024

  1. * Fix for spatially varying Bodner fields.

    - Without this, one can see the tile boundaries in the uhml and vhml
      fields.
    kshedstrom authored and marshallward committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    a78aa57 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2024

  1. Fix USE_CONT_THICKNESS bug

    Optionally correct a bug due to a missing halo exchange.  This likely
    isn't needed when compiled for nonsymmetric memory, but the added halo
    exchange does no harm in such cases.  The pass_vector call could probably
    be replaced with fill_symmetric_edges, except there is no subroutine
    fill_vector_symmetric_edges_3d.
    
    USE_CONT_THICKNESS is not yet widely used, so rather than preserving the old
    (incorrect) solutions by default, this bug is corrected by default.  However,
    the previous answers can be recovered by setting the new runtime parameter
    USE_CONT_THICKNESS_BUG to true.  This parameter is only used (and logged)
    when USE_CONT_THICKNESS set to true.
    
    By default, this commit does change answers in symmetric memory cases with
    USE_CONT_THICKNESS = True, and there is a new runtime parameter in such cases.
    awallcraft authored and marshallward committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    42c1a32 View commit details
    Browse the repository at this point in the history
  2. Directional linear wave drag (NOAA-GFDL#703)

    * Directional linear wave drag
    
    This commit allows the linear wave drag to be applied to the u and
    v components of the barotropic velocity separately.
    c2xu authored Aug 21, 2024
    Configuration menu
    Copy the full SHA
    2024f6f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d234bce View commit details
    Browse the repository at this point in the history