Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize poetry in README.md, and fix up docs #35

Merged
merged 2 commits into from
Sep 9, 2023
Merged

Standardize poetry in README.md, and fix up docs #35

merged 2 commits into from
Sep 9, 2023

Conversation

amorehead
Copy link
Collaborator

@amorehead amorehead commented Sep 9, 2023 •
edited
Loading

  • Moves poetry details to the For developers section in the README.
  • All docs pages have been updated to match up with the line numbers in README.md.
  • Also fixed up some docstrings for different encoders.
  • The docs will need to be redeployed after merging this in.
  • This should address the issue: Highlight local pip install option in docs #29.

@amorehead amorehead mentioned this pull request Sep 9, 2023
Closed
@a-r-j
Copy link
Owner

a-r-j commented Sep 9, 2023

LGTM. Great work, thanks Alex!

@a-r-j a-r-j merged commit 7cd801e into main Sep 9, 2023
9 of 10 checks passed
@amorehead amorehead deleted the standardize-readme-and-docs branch September 9, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amorehead @a-r-j