Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raw files hotfix #23 #24

Merged
merged 13 commits into from
Aug 30, 2023
Merged

Raw files hotfix #23 #24

merged 13 commits into from
Aug 30, 2023

Conversation

a-r-j
Copy link
Owner

@a-r-j a-r-j commented Aug 29, 2023

  • Skips structure download if overwrite=False and all processed files are found.

@a-r-j a-r-j changed the title Raw files hotfix Raw files hotfix #23 Aug 29, 2023
@amorehead
Copy link
Collaborator

LGTM. If it tests fine with e.g., CASP vs. astral, I think this should be good to go.

@a-r-j
Copy link
Owner Author

a-r-j commented Aug 30, 2023

  • FoldComp downloads would fail if that target directory name is the same as the database. This is because FoldComp downloads into pwd, then moves the files. I added a fix to cd into the target, download, then cd back to the original location.

Applying a similar patch to graphein: a-r-j/graphein#339

Once that PR is merged, I'll update the minimum Graphein version for proteinworkshop

@a-r-j a-r-j merged commit ca0f770 into main Aug 30, 2023
1 check passed
@amorehead amorehead deleted the raw_files_hotfix branch August 30, 2023 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@a-r-j @amorehead