Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed dependency versions #427

Closed
jeromegrosse opened this issue Feb 20, 2017 · 6 comments
Closed

Fixed dependency versions #427

jeromegrosse opened this issue Feb 20, 2017 · 6 comments
Labels
project-admin Anything to do with the administration & organisation of moviepy. I.e. project "meta".

Comments

@jeromegrosse
Copy link
Contributor

jeromegrosse commented Feb 20, 2017

On this line the versions of the dependencies are not specified, which can create a problem as it can create compatibility problems in case of breaking changes from upstream.

@tburrows13
Copy link
Collaborator

Do you mean we should be specifying minimum versions or maximum versions on dependencies?

@jeromegrosse
Copy link
Contributor Author

We should specify the versions on which we know moviepy works. If one of the dependency gets a new version, even one with breaking changes, moviepy will stop working as it will download the latest dependencies.

I created this issue as I encountered this very problem. Tomorrow I'll try to give a snippet that can reproduce the error. :)

@keikoro
Copy link
Collaborator

keikoro commented Mar 1, 2017

Yeah, I agree the version numbers should be fixed, and only be ones that we know work.

@jeromegrosse
Copy link
Contributor Author

jeromegrosse commented Mar 6, 2017

So, a bit of a follow up.

I'm not sure if it is better to create an issue but I'll first mention the errors here.

First of all, with the last version of movieio, in my case it is necessary to execute the command: import imageio; imageio.plugins.ffmpeg.download() for executing anything related with ffmpeg. It wasn't necessary with movieio 1.6 as it was bundled in the package.

I also encounter this issue: #376 . it is apparently related to the update of numpy, which could also be avoided if storing the dependencies versions within the setup.py file.

I'd like to mention that I'm happy to see this project live again with the PR and issues being attended. 👍

@Julian-O
Copy link
Contributor

Julian-O commented Aug 8, 2017

There have been some improvements in #626 for this.

Locking in to a fixed version is problematic, because:

  • Users won't get bug fixes, including security patches.
  • It doesn't play well with others. If other packages insist on a different version, there will be a version conflict.
  • Binaries might not exist for the version we demand, meaning that rebuilds are required. This is not trivial on every platform.

Semantic versioning allows us to specify that we accept any version, from the version we know works, up to the next breaking change (indicated by the first digit), so we can take advantage of that in the setup.py specifications.

@keikoro keikoro added the project-admin Anything to do with the administration & organisation of moviepy. I.e. project "meta". label Nov 25, 2017
@tburrows13
Copy link
Collaborator

All sorted in v2.0, if not before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
project-admin Anything to do with the administration & organisation of moviepy. I.e. project "meta".
Projects
None yet
Development

No branches or pull requests

4 participants