-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ConstructRemoveAuthorizedParty #48
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like some copy-pasting bugs
params := &multisigV1.ProposeParams{ | ||
To: to, | ||
Value: types.NewInt(0), | ||
Method: builtinV1.MethodsMultisig.SwapSigner, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be calling RemoveSigner
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good 👁️ s. @raynaudoe can we fix it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oopsss 👍
we definitely need a bit more coverage here
params := &multisigV2.ProposeParams{ | ||
To: to, | ||
Value: types.NewInt(0), | ||
Method: builtinV2.MethodsMultisig.SwapSigner, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be calling RemoveSigner
Decrease bool `json:"decrease"` | ||
} | ||
|
||
// RemoveAuthorizedPartyRequest defines the input to ConstructSwapAuthorizedParty |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment is incorrect, should be ConstructRemoveAuthorizedParty
Add test