Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make subchunkable usable by people who don't want to divide #401

Closed
supersergiy opened this issue May 20, 2023 · 2 comments · Fixed by #426
Closed

Make subchunkable usable by people who don't want to divide #401

supersergiy opened this issue May 20, 2023 · 2 comments · Fixed by #426
Assignees
Labels
enhancement New feature or request subchunkable

Comments

@supersergiy
Copy link
Member

There's 3 types of bbox expansion:

  1. Resolution based expansion -- bbox given by the user does not evenly divide by the dst_resolution.
  2. Bunk based expansion -- bbox given by the user doesn't align with bunk of the dst layer.
  3. Punk based expansion -- .... with top level punk .... This is implemented as expand_bbox rn, and it moves bottom right corner.

Proposal:
Make each one of them a boolean parameter, apply those parameters independently in 1->2->3 order.

When both (2) and (3) are set, require some sort of divisibility between top level punk and dst.bunk.

@supersergiy
Copy link
Member Author

@dodamih What do you think about the last possible mode:

Do (1) and (3), not (2), and allow non-alligned writes during the final write, either everywhere or at the boundaries only

@dodamih
Copy link
Collaborator

dodamih commented May 25, 2023

It's not difficult in principle, but we have enough case checking as is at the moment which will only increase with the PR that will fix this - I think allowing non-aligned writes at the top level should be a separate issue that we can deal with once we have docs.

Subchunkable is going to have 25 total possible arguments with the latest integration test PR and the expand + direct write PR - we're at a point where it's difficult for me to keep track of and reason through how all the args affecting BBox interact with each other.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request subchunkable
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants