Latest version of VSCode breaks City Lights for Babel Language

[mfix22]

Everything just looks gray and blue now 🤷‍♂

[noudadrichem]

What is the 'latest version' ? Everything looks fine on my machine.

[mfix22]

I'll close this until I can investigate further. Sorry about the poorly formed issue — was in too big of a rush!

[mfix22]

Maybe I am wrong, but I thought components are supposed to be rendered as not gray

[noudadrichem]

This is true!
Can you provide some more details on versions etc.? I'm still not facing this issue. So a bit more context would be great for me to investigate further.

Thank you in advance!

[mfix22]

Code version: 1.41.1
City lights version: 1.1.5
Babel Javascript (by Michael McDermott) version: 0.0.25

Using macOS, Mojave, 10.14.6

Let me know if there is anything else that would help!

[FezVrasta]

I can reproduce the same issue, comparing the generated markup/html with the default vscode editor and city lights, I see that the default theme wraps < and the component name in two different span

While city lights wraps both in the same:

[noudadrichem]

Hi @mfix22

I think this is due too new updates on how colors are processed...
I'm looking into it at the moment. But for now you can disable semantic highlighting and all should work as the old!

Add "editor.semanticHighlighting.enabled": false to your settings.json

[noudadrichem]

Hi @FezVrasta,

I'm not sure what you want me to do with a HTML screenshots of VSCode. We don't change any HTML on purpose as the colors are 'just' processed from a JSON file.

[FezVrasta]

@noudadrichem I don't know, I just noticed this difference and reported back, I have no knowledge about this so I was just trying to be useful.

To be clear, those screenshots are from the vscode dev tools, it's not my own code obviously, it's just the markup generated by vscode to highlight the same segment of code with the two themes.

[FezVrasta]

editor.semanticHighlighting.enabled is already set to false on my environment anyways.

[mfix22]

Add "editor.semanticHighlighting.enabled": false to your settings.json

@noudadrichem thank you! I will give this a shot 👍

[mfix22]

I am still noticing the issue. The one difference between the two computers I have this theme installed on is that the one using the Babel JavaScript plugin by Michael McDermott is showing the issue above, and the other one isn't, regardless of my editor.semanticHighlighting.enabled setting.