Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issues about assign_lineage_groups() function #187

Open
AmoriLi opened this issue Nov 22, 2022 · 0 comments
Open

issues about assign_lineage_groups() function #187

AmoriLi opened this issue Nov 22, 2022 · 0 comments

Comments

@AmoriLi
Copy link

AmoriLi commented Nov 22, 2022

Thanks for developing such a useful tool for reconstructing phylogenetic tree. when looking into the source code of assigning lineage groups to each cells, I am not sure about if it is correct in several details. There are two main questions confusing me as follows:

https://github.com/YosefLab/Cassiopeia/blob/master/cassiopeia/preprocess/lineage_utils.py
1.
Screen Shot 2022-11-23 at 12 01 02 AM
in the last 3rd line, should it be 'prev_clust_size = piv_nolg.shape[0]' because we only need to assign lineage group to the undefined cells with number more than 'min_clust_size'. Is there something important I've missed or misunderstood?

Screen Shot 2022-11-23 at 12 09 28 AM

Screen Shot 2022-11-23 at 12 11 21 AM

the above intBC set was used in iteratively assignment of lineage groups and the bottom one master_intBC was applied to calculate kinship_score. but these two intBC sets were actually not same because they were filtered via different criteria. so I am wondering if it is more efficient and accurate than using the same criteria to selecting intBC set and master_intBC?

Hope I have got the meaning of your code and looking forward to your reply~

@AmoriLi AmoriLi changed the title issues about assidgn_lineage_groups() function issues about assign_lineage_groups() function Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant