Skip to content
This repository has been archived by the owner on Oct 4, 2022. It is now read-only.

Highlighting is lost after clicking on one of multiple highlights #1218

Closed
rmarcano opened this issue Aug 4, 2017 · 7 comments
Closed

Highlighting is lost after clicking on one of multiple highlights #1218

rmarcano opened this issue Aug 4, 2017 · 7 comments

Comments

@rmarcano
Copy link

rmarcano commented Aug 4, 2017

What did you expect to happen?

All occurrences of an issue to remain highlighted after clicking on the editor to correct said issues.

What happened instead?

When a readability issue appears multiple times, the highlighting is lost when clicking on one of them.

How can we reproduce this behavior?

  1. In a piece of content insert several long sentences. This should trigger the warning: "X% of the sentences contain more than 20 words, which is more than the recommended maximum of 25%. Try to shorten the sentences."

  2. Highlight the offending sentences using the eye icon. Notice that all occurrences of long sentences are highlighted.

  3. Scroll up to the post editor to correct the first of the offending long sentences. Note that the highlighting on all other offending sentences are lost, forcing the user scroll back down and click the "Eye" icon once again, scroll back up, fix the sentence. Repeat for every single occurrence of the issue.

Technical info

  • Platform: WordPress
  • Platform version: 4.8.1
  • Yoast SEO version:5.1
@rmarcano
Copy link
Author

rmarcano commented Aug 4, 2017

Please inform the customer of conversation # 213081 when this conversation has been closed.

@rmarcano
Copy link
Author

Please inform the customer of conversation # 229168 when this conversation has been closed.

@omarreiss
Copy link
Contributor

This was a compromise we took since we found it very hard to keep the cursor in place while highlighting and wanted to prevent potential bugs that would arise in association with it. At the same time, we are looking if this could potentially be facilitated in the new WordPress editor (Gutenberg). See WordPress/gutenberg#2893

@rmarcano
Copy link
Author

Please inform the customer of conversation # 260823 when this conversation has been closed.

@michaelbriantina
Copy link

Please inform the customer of conversation # 418075 when this conversation has been closed.

@michaelbriantina
Copy link

Please inform the customer of conversation # 440905 when this conversation has been closed.

@moorscode
Copy link
Contributor

We have been working hard to implement the annotations API and highlighting in Gutenberg.
The current state is that it is implemented and the highlights will remain even when clicking inside the content. This only works with Gutenberg and will not be implemented in the Classic editor for the same reasons mentioned before.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants