fix(eventstore): lowercase method - appendToStream

This would be a breaking change if I was already versioning properly, but meh... Fixes #255
YannickMeeus · Sep 21, 2020 · f9d2d49 · f9d2d49
1 parent e868021
commit f9d2d49
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 21 deletions.
diff --git a/src/EventStore.ts b/src/EventStore.ts
@@ -26,7 +26,7 @@ class EventStore {
    * @returns {Promise<void>}
    * @memberof EventStore
    */
-  public AppendToStream(
+  public appendToStream(
     streamId: string,
     expectedVersion: number,
     ...events: EventData[]

diff --git a/test/EventStore.Appending.test.ts b/test/EventStore.Appending.test.ts
@@ -12,7 +12,7 @@ describe('Given a set of engines to test against', () => {
 
   const newGuid = () => uuid.v4()
 
-  engineFactories.forEach(getEngine => {
+  engineFactories.forEach((getEngine) => {
     const engine = getEngine()
 
     const getStore = async () => {
@@ -22,12 +22,12 @@ describe('Given a set of engines to test against', () => {
     describe('When appending to a new stream', () => {
       describe('And the stream id is invalid', () => {
         const invalidStreamIds = [undefined, null, '', ' ']
-        invalidStreamIds.forEach(invalidStreamId => {
+        invalidStreamIds.forEach((invalidStreamId) => {
           it(`It should throw an error for stream id: '${invalidStreamId}'`, async () => {
             const eventStore = await getStore()
             const event = new EventData(newGuid(), 'BODY')
             try {
-              await eventStore.AppendToStream(invalidStreamId as string, 0, event)
+              await eventStore.appendToStream(invalidStreamId as string, 0, event)
             } catch (e) {
               expect(e.message).toEqual(
                 'streamId can not be null, empty string or contain only whitespace'
@@ -44,7 +44,7 @@ describe('Given a set of engines to test against', () => {
 
         it('It should save both events and allow them to be retrievable', async () => {
           const sut = await getStore()
-          await sut.AppendToStream(streamId, 0, ...eventsToSave)
+          await sut.appendToStream(streamId, 0, ...eventsToSave)
 
           const savedEvents = await sut.readStreamForwards(streamId)
 
@@ -64,7 +64,7 @@ describe('Given a set of engines to test against', () => {
         const sut = await getStore()
         const event = new EventData(newGuid(), new OrderCreated(streamId))
 
-        await sut.AppendToStream(streamId, 0, event)
+        await sut.appendToStream(streamId, 0, event)
 
         const stream = await sut.readStreamForwards(streamId)
         expect(stream.length).toEqual(1)
@@ -79,14 +79,14 @@ describe('Given a set of engines to test against', () => {
         }
 
         const metaData: SomeMetaData = {
-          value: 'foo'
+          value: 'foo',
         }
 
         const streamId = newGuid()
         const sut = await getStore()
         const event = new EventData(newGuid(), new OrderCreated(streamId), metaData)
 
-        await sut.AppendToStream(streamId, 0, event)
+        await sut.appendToStream(streamId, 0, event)
         const stream = await sut.readStreamForwards(streamId)
         const savedEvent = stream.pop() as EventStorage
         expect(savedEvent.metaData as SomeMetaData).toEqual(metaData)
@@ -98,9 +98,9 @@ describe('Given a set of engines to test against', () => {
         const sut = await getStore()
         const firstEvent = new EventData(newGuid(), new OrderCreated(streamId))
         const secondEvent = new EventData(newGuid(), new OrderDispatched(streamId))
-        await sut.AppendToStream(streamId, 0, firstEvent)
+        await sut.appendToStream(streamId, 0, firstEvent)
 
-        await sut.AppendToStream(streamId, 1, secondEvent)
+        await sut.appendToStream(streamId, 1, secondEvent)
 
         const stream = await sut.readStreamForwards(streamId)
 
@@ -112,29 +112,29 @@ describe('Given a set of engines to test against', () => {
     })
     describe('When appending to a new stream with an unexpected version', () => {
       const invalidRevisions = [-1, 1, 2, 99]
-      invalidRevisions.forEach(invalidRevision => {
+      invalidRevisions.forEach((invalidRevision) => {
         it(`It should throw a concurrency error with revision number: '${invalidRevision}'`, async () => {
           const streamId = newGuid()
           const sut = await getStore()
           const event = new EventData(newGuid(), new OrderDispatched(streamId))
 
-          await expect(sut.AppendToStream(streamId, invalidRevision, event)).rejects.toThrow(
+          await expect(sut.appendToStream(streamId, invalidRevision, event)).rejects.toThrow(
             'Concurrency conflict'
           )
         })
       })
     })
     describe('When appending to an existing stream with an unexpected version', () => {
       const invalidRevisions = [0, 2]
-      invalidRevisions.forEach(invalidRevision => {
+      invalidRevisions.forEach((invalidRevision) => {
         it(`It should throw a concurrency error with revision number: '${invalidRevision}'`, async () => {
           const streamId = newGuid()
           const sut = await getStore()
 
           const existingEvent = new EventData(newGuid(), new OrderCreated(streamId))
           const newEvent = new EventData(newGuid(), new OrderDispatched(streamId))
-          await sut.AppendToStream(streamId, 0, existingEvent)
-          await expect(sut.AppendToStream(streamId, invalidRevision, newEvent)).rejects.toThrow(
+          await sut.appendToStream(streamId, 0, existingEvent)
+          await expect(sut.appendToStream(streamId, invalidRevision, newEvent)).rejects.toThrow(
             'Concurrency conflict'
           )
         })

diff --git a/test/EventStore.Deleting.test.ts b/test/EventStore.Deleting.test.ts
@@ -43,8 +43,8 @@ describe('Given a set of engines to test against', () => {
         const firstEvent = new EventData(newGuid(), new OrderCreated(streamId))
         const secondEvent = new EventData(newGuid(), new OrderDispatched(streamId))
 
-        await sut.AppendToStream(streamId, 0, firstEvent)
-        await sut.AppendToStream(streamId, 1, secondEvent)
+        await sut.appendToStream(streamId, 0, firstEvent)
+        await sut.appendToStream(streamId, 1, secondEvent)
 
         const stream = await sut.readStreamForwards(streamId)
 

diff --git a/test/EventStore.Reading.test.ts b/test/EventStore.Reading.test.ts
@@ -49,8 +49,8 @@ describe('Given a set of engines to test against', () => {
         const firstEvent = new EventData(newGuid(), new OrderCreated(streamId))
         const secondEvent = new EventData(newGuid(), new OrderDispatched(streamId))
 
-        await sut.AppendToStream(streamId, 0, firstEvent)
-        await sut.AppendToStream(streamId, 1, secondEvent)
+        await sut.appendToStream(streamId, 0, firstEvent)
+        await sut.appendToStream(streamId, 1, secondEvent)
 
         const stream = await sut.readStreamForwards(streamId)
 
@@ -64,8 +64,8 @@ describe('Given a set of engines to test against', () => {
         const firstEvent = new EventData(newGuid(), new OrderCreated(streamId))
         const secondEvent = new EventData(newGuid(), new OrderDispatched(streamId))
 
-        await sut.AppendToStream(streamId, 0, firstEvent)
-        await sut.AppendToStream(streamId, 1, secondEvent)
+        await sut.appendToStream(streamId, 0, firstEvent)
+        await sut.appendToStream(streamId, 1, secondEvent)
 
         const subsetOfStream = await sut.readStreamForwards(streamId, 2, 1)