Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Give XbeXbSymbolDatabaseAnalyzer Higher Priority #15

Open
RadWolfie opened this issue Oct 25, 2020 · 1 comment
Open

Request: Give XbeXbSymbolDatabaseAnalyzer Higher Priority #15

RadWolfie opened this issue Oct 25, 2020 · 1 comment

Comments

@RadWolfie
Copy link
Contributor

RadWolfie commented Oct 25, 2020

When I did first analysis scan, I notice pretty much almost every xbox's library symbols are not disassemble. Unless I do a second analysis. That means whenever new symbols are found and added, we have to run analysis twice maximum to complete disassembly process.

I had been looking into how to give this extension higher priority. I found couple references from ghidra's obsolete plugins except they are deleted. And another reference from a third-party extension. When I try to add import ghidra.util.classfinder.ExtensionPointProperties; and @ExtensionPointProperties(priority = 2) to XbeXbSymbolDatabaseAnalyzer.java file. It made an error about ExtensionPointProperties import not found.

By giving higher priority for this extension can resolve unnecessary redundant analysis scans.

References:

EDIT:
Base on Ghidra's doc, there isn't any reference to ExtensionPointProperties interface.

@RadWolfie
Copy link
Contributor Author

UPDATE:
With Ghidra 9.2 support, I am able to compile with ExtensionPointProperties usage. Except it is still not given top priority. I also tried setPriority call which didn't help at all. I am stumped with how exactly extension give first priority over Ghidra built-in services. In simple term, XbeXbSymbolDatabaseAnalyzer is still called last.

Also, I'm not sure if we do still need Ghidra-Xbe top priority. Since I notice the rest of the disassembly on first run appear to be more complete than Ghidra 9.1.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant