"--skip_validate" arg for xls2xform.py #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes were required to get all nosetests to pass. - Java installed check falls back to Windows-specific method on WindowsError. - Parsing stderr from the ODK Validate call falls back to latin-1 on UnicodeDecodeError. - Exclusive NamedTemporaryFile handling since Windows doesn't allow simultaneous access.
Bundled version doesn't seem to work with Popen calls. - OK: double-click jar and validate xml file. - Not OK: running nosetests using validate, these fail with java NoClassDefFound exceptions. The included jar is a fresh ant build using jdk1.7.0_80, and works in both above contexts. - packaged from getodk/validate@65444de
- This hooks in to existing option in print_xform_to_file so no tests for how it reacts to True or False - New _create_parser function wraps parser creation for testability. - Other __main__ code put inside a wrapper function to keep the module namespace tidy.
|
@lindsay-stevens, thank you for getting this working in windows. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c758940 Exposes the existing option in survey.print_xform_to_file to not run ODK_Validate on the output XML file, as an optional argument "--skip_validate" on the command line.
94c759c Before I could get started on this there were a couple of Windows-specific problems preventing the nosetests from running. In each case I've tried to make it so that the original behaviour will be attempted, then try the Windows route, and then fail after that. All the tests pass for me on Windows 7 x64 with these changes. It's passing in travis-ci so I guess it's Linux compatible too. https://travis-ci.org/lindsay-stevens/pyxform/builds/126578491.
a57ab51 I also had trouble with the bundled ODK_Validate.jar; when running the tests, the
java -jarcall would error out with NoClassDefFound exceptions. I think it is something to do with the "jar inside a jar" structure. So I re-packaged it from the validate repo as of 2016-04-29 getodk/validate@65444de and it worked.