Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed "from pyxform import constants" to "import constants" in survey.py #62

Merged
merged 1 commit into from
Apr 17, 2016

Conversation

ivangayton
Copy link

Hi, I just tried to use xls2xform from a fresh download, and got an error related to the import of constants in survey.py. Turns out the import read 'from pyxform import constants', so it was looking for a file called pyxform.py. I changed the import to read simply 'import constants' (referring to constants.py, which does exist and appears to contain the relevant code), this appears to have fixed the problem; I can now convert forms from the command line.

I don't know the codebase, so I may very well have missed some other reason why this is not correct. I'm fine working from my temporary fork if you don't want to merge this, or if you want to take the time to do something more sensible!

Thanks (and thanks for creating this; it's incredibly useful to me and the organizations I work for, Medecins Sans Frontieres and the Red Cross)!

@dorey
Copy link
Contributor

dorey commented Apr 17, 2016

All tests pass, and looks good. Thanks @ivangayton.

@dorey dorey merged commit bb756c4 into XLSForm:master Apr 17, 2016
@ivangayton
Copy link
Author

Great, thanks @dorey!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants