Changed "from pyxform import constants" to "import constants" in survey.py #62
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I just tried to use xls2xform from a fresh download, and got an error related to the import of constants in survey.py. Turns out the import read 'from pyxform import constants', so it was looking for a file called pyxform.py. I changed the import to read simply 'import constants' (referring to constants.py, which does exist and appears to contain the relevant code), this appears to have fixed the problem; I can now convert forms from the command line.
I don't know the codebase, so I may very well have missed some other reason why this is not correct. I'm fine working from my temporary fork if you don't want to merge this, or if you want to take the time to do something more sensible!
Thanks (and thanks for creating this; it's incredibly useful to me and the organizations I work for, Medecins Sans Frontieres and the Red Cross)!