Release v1.3.4 #512
Merged
Release v1.3.4 #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #512 +/- ##
=======================================
Coverage 83.81% 83.81%
=======================================
Files 25 25
Lines 3694 3694
Branches 860 860
=======================================
Hits 3096 3096
Misses 453 453
Partials 145 145
Continue to review full report at Codecov.
|
|
Yes, I've been not very good and just let those slide. I believe all of them just need slight reworks of the tests (e.g. using a valid function name, not having cycles, indexing into all repeats). |
yanokwa
approved these changes
Jan 14, 2021
|
Thank you! |
KeynesYouDigIt
pushed a commit
to KeynesYouDigIt/pyxform
that referenced
this pull request
May 23, 2021
* Release v1.3.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed there are 10 failing ODK Validate tests (step 2 of release steps), but that was the case in the previous version as well, and I'm guessing may have been the case for much longer. Are we just ignoring this?