Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make value ref dynamic for selects from repeats #493

Merged
merged 1 commit into from
Dec 9, 2020

Conversation

lognaturel
Copy link
Contributor

#472 added support for selects from repeats but it did not make the value ref dynamic so only fields with the name name could be used.

Why is this the best possible solution? Were any other approaches considered?

This matches the way the label ref is set and is simple to understand.

What are the regression risks?

One risk I thought of is that if itemset_value_ref is in the wrong place, some select cases could end up without a ref set.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

  • included test cases for core behavior and edge cases in tests_v1
  • run nosetests and verified all tests pass
  • run black pyxform to format code
  • verified that any code or assets from external sources are properly credited in comments

@codecov-io
Copy link

codecov-io commented Dec 9, 2020

Codecov Report

Merging #493 (f1a9780) into master (87325c5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #493   +/-   ##
=======================================
  Coverage   83.84%   83.85%           
=======================================
  Files          25       25           
  Lines        3690     3692    +2     
  Branches      860      860           
=======================================
+ Hits         3094     3096    +2     
  Misses        452      452           
  Partials      144      144           
Impacted Files Coverage Δ
pyxform/question.py 93.36% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87325c5...f1a9780. Read the comment docs.

Copy link
Contributor

@DavisRayM DavisRayM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lognaturel lognaturel merged commit 3862b52 into XLSForm:master Dec 9, 2020
@lognaturel lognaturel deleted the dynamic-name branch December 9, 2020 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants