Support ref in constraint and required messages with single language #487
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #474
Why is this the best possible solution? Were any other approaches considered?
Discussed approach in the issue and @MartijnR agreed identifying
${}
references and forcing itext creation in that case was our best bet.In terms of implementation, I tried to reduce redundancy in this section but I couldn't come up with any approach that would be easy to read. I think this is ok because the conditions are linear and read well.
I considered adding tests for relative references in repeats but I think that's sufficiently covered elsewhere and should Just Work.
What are the regression risks?
Everything I added is in a conditional so I think risks are minimal. The worst risk is probably that I would have forgotten some cases.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No, this is a bug fix.
Before submitting this PR, please make sure you have:
tests_v1
nosetests
and verified all tests passblack pyxform
to format code