Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 471 deprecate unused device id methods #473

Conversation

KeynesYouDigIt
Copy link
Contributor

Closes #471

Why is this the best possible solution? Were any other approaches considered?

This adds warnings where other question type specific warnings are. This pattern is modelled after the special validation work used for 'audit' and 'calculate' question types.

I considered checking this information upstream in the survey creation process, but would have to re-divide the sheet into rows. Downstream, during question creation and final survey creation, is another place where warnings can be generated, but we have the information we need at the point where the warnings were added, so no point in working further down.

What are the regression risks?

I did modify constants.py - any modification of a global config represents some regression risk. However, values were only added, and only values that apply to my use case, and only under a name that does not conflict with another name, so I do not see any great risks.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

docs should already be set https://github.com/XLSForm/xlsform.github.io/pull/208/files

Before submitting this PR, please make sure you have:

  • [ x ] included test cases for core behavior and edge cases in tests_v1
  • [ x ] run nosetests and verified all tests pass
  • [ x ] run black pyxform to format code
  • [ x ] verified that any code or assets from external sources are properly credited in comments

Copy link
Contributor

@lognaturel lognaturel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

pyxform/tests/xlsform_spec_test.py Outdated Show resolved Hide resolved
pyxform/tests_v1/test_metadata.py Show resolved Hide resolved
pyxform/tests_v1/test_metadata.py Outdated Show resolved Hide resolved
@KeynesYouDigIt KeynesYouDigIt force-pushed the issue_471_deprecate_unused_device_id_methods branch from 4cbd728 to efbc95b Compare October 17, 2020 21:51
Copy link
Contributor

@lognaturel lognaturel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super, thanks so much!!

@lognaturel lognaturel merged commit 4d36a08 into XLSForm:master Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display warning when using simserial or subscriberid
2 participants