Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1.2.0 release #470

Merged
merged 1 commit into from
Sep 11, 2020
Merged

v1.2.0 release #470

merged 1 commit into from
Sep 11, 2020

Conversation

yanokwa
Copy link
Contributor

@yanokwa yanokwa commented Sep 10, 2020 •
edited
Loading

Following the steps at https://github.com/XLSForm/pyxform#releasing-pyxform.

Before submitting this PR, please make sure you have:

  • included test cases for core behavior and edge cases in tests_v1
  • run nosetests and verified all tests pass
  • run black pyxform to format code
  • verified that any code or assets from external sources are properly credited in comments

lognaturel
lognaturel approved these changes Sep 11, 2020
View reviewed changes
Copy link
Contributor

@lognaturel lognaturel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I forgot to do those things!

@lognaturel lognaturel merged commit d4b4e28 into XLSForm:master Sep 11, 2020
@yanokwa yanokwa deleted the v1.2.0 branch October 13, 2021 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lognaturel lognaturel lognaturel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yanokwa @lognaturel