Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 454 calculate with dynamic default #456

Merged
merged 3 commits into from
Jul 23, 2020
Merged

Fix 454 calculate with dynamic default #456

merged 3 commits into from
Jul 23, 2020

Conversation

gushil
Copy link
Contributor

@gushil gushil commented Jul 11, 2020

Closes #
#454

Why is this the best possible solution? Were any other approaches considered?

I think this is the simplest solution.

What are the regression risks?

I don't think there is any.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No

Before submitting this PR, please make sure you have:

  • included test cases for core behavior and edge cases in tests_v1
  • run nosetests and verified all tests pass
  • run black pyxform to format code
  • verified that any code or assets from external sources are properly credited in comments

@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2020

Codecov Report

Merging #456 into master will decrease coverage by 0.19%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #456      +/-   ##
==========================================
- Coverage   83.11%   82.91%   -0.20%     
==========================================
  Files          25       25              
  Lines        3595     3553      -42     
  Branches      833      833              
==========================================
- Hits         2988     2946      -42     
  Misses        460      460              
  Partials      147      147              
Impacted Files Coverage Δ
pyxform/xls2json.py 78.03% <100.00%> (+0.03%) ⬆️
pyxform/validators/error_cleaner.py 83.33% <0.00%> (-2.09%) ⬇️
pyxform/validators/updater.py 82.00% <0.00%> (-1.11%) ⬇️
pyxform/builder.py 76.73% <0.00%> (-0.46%) ⬇️
pyxform/validators/util.py 75.78% <0.00%> (-0.26%) ⬇️
pyxform/survey.py 91.34% <0.00%> (-0.18%) ⬇️
pyxform/xform2json.py 79.33% <0.00%> (-0.09%) ⬇️
pyxform/survey_element.py 90.08% <0.00%> (-0.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0bd9d4...d0c5f1c. Read the comment docs.

@MartijnR
Copy link
Contributor

Thanks! Looks good to me judging from the tests.

@MartijnR MartijnR requested a review from lognaturel July 16, 2020 19:38
@lognaturel lognaturel merged commit c46e853 into XLSForm:master Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants