-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Put setvalue action for repeats in the body #431
Conversation
97aaa42
to
7c16a6a
Compare
Codecov Report
@@ Coverage Diff @@
## master #431 +/- ##
==========================================
+ Coverage 82.72% 82.81% +0.09%
==========================================
Files 23 23
Lines 3386 3399 +13
Branches 786 790 +4
==========================================
+ Hits 2801 2815 +14
Misses 439 439
+ Partials 146 145 -1
Continue to review full report at Codecov.
|
5e25f2e
to
c24e42c
Compare
result.append(dynamic_default) | ||
|
||
# dynamic defaults for repeats go in the body. All other dynamic defaults (setvalue actions) go in the model | ||
if ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was beautiful before black
got its hands on it.
| | date | date | Date | now() | | ||
| | integer | foo | Foo | | | ||
| | begin repeat | inner | | | | ||
| | integer | bar | Bar | ${foo} | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This illustrates the problem with always having a first instance of a repeat that I described at #182 (comment)
Closes #427
This fixes the regression introduced by 266ef19. The regression was because I didn't understand what the
in_binding
parameter did and because there was no test coverage for the desired behavior so I added tests and did some refactoring.While doing this, I realized that dynamic defaults in groups or repeats nested within repeats weren't being handled as expected. c24e42c adds test coverage and a fix for this.