Put setvalue action for repeats in the body #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lognaturel
force-pushed
the
issue-427
branch
from
97aaa42
to
7c16a6a
Compare
Codecov Report
@@ Coverage Diff @@
## master #431 +/- ##
==========================================
+ Coverage 82.72% 82.81% +0.09%
==========================================
Files 23 23
Lines 3386 3399 +13
Branches 786 790 +4
==========================================
+ Hits 2801 2815 +14
Misses 439 439
+ Partials 146 145 -1
Continue to review full report at Codecov.
|
lognaturel
force-pushed
the
issue-427
branch
from
5e25f2e
to
c24e42c
Compare
lognaturel
commented
Feb 14, 2020
| result.append(dynamic_default) | ||
|
|
||
| # dynamic defaults for repeats go in the body. All other dynamic defaults (setvalue actions) go in the model | ||
| if ( |
There was a problem hiding this comment.
This was beautiful before black got its hands on it.
lognaturel
commented
Feb 14, 2020
| | | date | date | Date | now() | | ||
| | | integer | foo | Foo | | | ||
| | | begin repeat | inner | | | | ||
| | | integer | bar | Bar | ${foo} | |
There was a problem hiding this comment.
This illustrates the problem with always having a first instance of a repeat that I described at #182 (comment)
yanokwa
approved these changes
Feb 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #427
This fixes the regression introduced by 266ef19. The regression was because I didn't understand what the
in_bindingparameter did and because there was no test coverage for the desired behavior so I added tests and did some refactoring.While doing this, I realized that dynamic defaults in groups or repeats nested within repeats weren't being handled as expected. c24e42c adds test coverage and a fix for this.