Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a hash to properly route to the choicenames url #429

Merged
merged 1 commit into from
Feb 12, 2020
Merged

Adding a hash to properly route to the choicenames url #429

merged 1 commit into from
Feb 12, 2020

Conversation

zachhweed
Copy link
Contributor

This is in relation to #428

Thanks!

@codecov-io
Copy link

codecov-io commented Feb 12, 2020

Codecov Report

Merging #429 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #429   +/-   ##
=======================================
  Coverage   82.72%   82.72%           
=======================================
  Files          23       23           
  Lines        3386     3386           
  Branches      786      786           
=======================================
  Hits         2801     2801           
  Misses        439      439           
  Partials      146      146
Impacted Files Coverage Δ
pyxform/xls2json.py 78% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5749d1...19a65ae. Read the comment docs.

@lognaturel
Copy link
Contributor

Thanks so much for picking this up, @zachhweed and welcome! If you're interested in working with pyxform more, check out https://forum.opendatakit.org/ to learn more about the ODK community and join the developer Slack channel #xlsform-code at https://slack.opendatakit.org/.

@lognaturel lognaturel merged commit 8dfd800 into XLSForm:master Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants