Clarify duplicate choice error message #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #418 +/- ##
==========================================
- Coverage 82.58% 82.57% -0.02%
==========================================
Files 23 23
Lines 3377 3374 -3
Branches 783 783
==========================================
- Hits 2789 2786 -3
Misses 442 442
Partials 146 146
Continue to review full report at Codecov.
|
|
Looks good to me! |
WinnyTroy
previously approved these changes
Jan 31, 2020
yanokwa
approved these changes
Jan 31, 2020
|
Thanks, @WinnyTroy! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #373
Introduces a clearer message for duplicate choices in the same list, linking out to documentation provided at XLSForm/xlsform.github.io#184.
For some reason, the case where no
allow_choice_duplicatessetting was defined was previously less informative than the case where the setting existed but was not set toyes. These now show the same message.