Ensure stable ordering of attributes for tests #413
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanokwa
force-pushed
the
fix-build
branch
3 times, most recently
from
40c022e
to
61bbf0a
Compare
yanokwa
changed the title
yanokwa
force-pushed
the
fix-build
branch
2 times, most recently
from
cc9e490
to
b875bc6
Compare
yanokwa
commented
Jan 7, 2020
yanokwa
force-pushed
the
fix-build
branch
3 times, most recently
from
448a2c3
to
9bec7ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 5c7c5a0, we use the same code from #412 to produce what I call "testable" XML (XML with a stable ordering). I couldn't find an easy way to de-duplicate the code without invasive changes. A more experienced Pythonista might know better.
9bec7ff, I narrowed the test to not depend on attribute order.