Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add track-changes-reason audit attribute #400

Merged
merged 5 commits into from
Dec 12, 2019

Conversation

seadowg
Copy link
Contributor

@seadowg seadowg commented Nov 28, 2019

This adds the track-changes-reasons as defined in this spec.

@seadowg
Copy link
Contributor Author

seadowg commented Nov 28, 2019

I don't understand the failures at all

@codecov-io
Copy link

codecov-io commented Dec 5, 2019

Codecov Report

Merging #400 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #400      +/-   ##
==========================================
+ Coverage   82.45%   82.48%   +0.03%     
==========================================
  Files          23       23              
  Lines        3265     3271       +6     
  Branches      764      766       +2     
==========================================
+ Hits         2692     2698       +6     
  Misses        432      432              
  Partials      141      141
Impacted Files Coverage Δ
pyxform/constants.py 100% <100%> (ø) ⬆️
pyxform/xls2json_backends.py 82.45% <100%> (ø) ⬆️
pyxform/xls2json.py 78.41% <100%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a619d24...478c084. Read the comment docs.

lognaturel
lognaturel previously approved these changes Dec 5, 2019
Copy link
Contributor

@lognaturel lognaturel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@ukanga, can you please help with the black failure? I can't tell whether black is somehow unsupported for those python versions all of a sudden or whether there are real problems.

@seadowg
Copy link
Contributor Author

seadowg commented Dec 6, 2019

For reference I did (from outside the repo dir):

pip install black
black --target-version=py27 pyxform

I'm using Python 3.7.4 and black 19.10b0.

@seadowg
Copy link
Contributor Author

seadowg commented Dec 9, 2019

@ukanga @lognaturel fixed this by using the same version of black that's in requirements.pip. I'll add a couple fo commits to the docs around this.

@lognaturel
Copy link
Contributor

I extra approve these. No comments and there's nothing controversial in here so let's merge so we can focus on the trickier open PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants