-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add track-changes-reason audit attribute #400
Conversation
I don't understand the failures at all |
Codecov Report
@@ Coverage Diff @@
## master #400 +/- ##
==========================================
+ Coverage 82.45% 82.48% +0.03%
==========================================
Files 23 23
Lines 3265 3271 +6
Branches 764 766 +2
==========================================
+ Hits 2692 2698 +6
Misses 432 432
Partials 141 141
Continue to review full report at Codecov.
|
f1c8616
to
81398db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
@ukanga, can you please help with the black failure? I can't tell whether black is somehow unsupported for those python versions all of a sudden or whether there are real problems.
For reference I did (from outside the repo dir):
I'm using Python 3.7.4 and black 19.10b0. |
@ukanga @lognaturel fixed this by using the same version of black that's in |
I extra approve these. No comments and there's nothing controversial in here so let's merge so we can focus on the trickier open PRs. |
This adds the
track-changes-reasons
as defined in this spec.