Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling quiet to see errors from black. #378

Merged
merged 2 commits into from
Oct 2, 2019

Conversation

nribeka
Copy link
Contributor

@nribeka nribeka commented Sep 30, 2019

Trying out to fix the black. Disabling the quiet flag and checking the output text.

Fix #379.

@codecov-io
Copy link

codecov-io commented Sep 30, 2019

Codecov Report

Merging #378 into master will increase coverage by 0.36%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #378      +/-   ##
==========================================
+ Coverage   81.94%   82.31%   +0.36%     
==========================================
  Files          23       23              
  Lines        3246     3246              
  Branches      758      758              
==========================================
+ Hits         2660     2672      +12     
+ Misses        444      435       -9     
+ Partials      142      139       -3
Impacted Files Coverage Δ
pyxform/xform2json.py 79.66% <0%> (+0.2%) ⬆️
pyxform/xls2json.py 77.95% <0%> (+0.31%) ⬆️
pyxform/survey.py 90% <0%> (+0.5%) ⬆️
pyxform/builder.py 75.4% <0%> (+0.53%) ⬆️
pyxform/survey_element.py 90.36% <0%> (+0.91%) ⬆️
pyxform/validators/util.py 77.89% <0%> (+2.1%) ⬆️
pyxform/validators/odk_validate/__init__.py 75.47% <0%> (+3.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e032f6...ef46ebd. Read the comment docs.

@nribeka nribeka marked this pull request as ready for review September 30, 2019 19:50
@yanokwa
Copy link
Contributor

yanokwa commented Oct 1, 2019

I'm not sure what problem this fixes. Is black failing? If so, can you file an issue or clarify the need in the PR.

@nribeka
Copy link
Contributor Author

nribeka commented Oct 1, 2019

@yanokwa added issue to try to explain the problem that I am seeing.

@ukanga ukanga merged commit 7a2cfa5 into XLSForm:master Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Circle CI failing on Python 3.6 and 3.7.
4 participants