Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google submissions do allow underscores #356

Merged
merged 1 commit into from
Sep 6, 2019
Merged

Google submissions do allow underscores #356

merged 1 commit into from
Sep 6, 2019

Conversation

yanokwa
Copy link
Contributor

@yanokwa yanokwa commented Sep 5, 2019

Closes #353 and reverts #299 because ODK Collect v1.23.3 allows submissions with underscores as shown here:
Screen Shot 2019-09-05 at 2 41 49 PM

For further proof, getodk/collect@3cca371 shows that the code in Collect that does this check was removed.

In the future, we really should test these PRs end to end before merging.

@yanokwa yanokwa requested a review from lincmba September 5, 2019 21:50
@lognaturel
Copy link
Contributor

To do a little post mortem here:

This is a tough one because integrations are involved. We obviously we have no control over Google Sheets and the folks who work on Collect and on pyxform are not all the same.

Some things we can improve:

At the end of the day, there are a lot of moving pieces here so not sure we could have done a whole lot better but I think it's helpful to think about what went wrong.

lognaturel
lognaturel previously approved these changes Sep 6, 2019
@yanokwa yanokwa merged commit a9fd520 into XLSForm:master Sep 6, 2019
@yanokwa yanokwa deleted the google-submission branch September 6, 2019 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Google Sheets warnings is overwhelming when there are many fields with underscores
2 participants