Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build artifacts on Circle CI #284

Merged
merged 1 commit into from
May 5, 2019
Merged

Build artifacts on Circle CI #284

merged 1 commit into from
May 5, 2019

Conversation

shobhitagarwal1612
Copy link
Contributor

@shobhitagarwal1612 shobhitagarwal1612 commented Mar 29, 2019 •
edited
Loading

Closes #283

Screenshot:
image

@codecov-io
Copy link

codecov-io commented Mar 29, 2019 •
edited
Loading

Codecov Report

Merging #284 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #284   +/-   ##
=======================================
  Coverage   81.19%   81.19%           
=======================================
  Files          23       23           
  Lines        3106     3106           
  Branches      729      729           
=======================================
  Hits         2522     2522           
  Misses        450      450           
  Partials      134      134

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 297dee7...6ef12ae. Read the comment docs.

@shobhitagarwal1612 shobhitagarwal1612 marked this pull request as ready for review March 29, 2019 21:16
@shobhitagarwal1612
Copy link
Contributor Author

@ukanga I can still see the appveyor task on the list. I think it has to be removed from the checklist in repository settings as well.

@shobhitagarwal1612
Copy link
Contributor Author

shobhitagarwal1612 commented Mar 30, 2019 •
edited
Loading

@ukanga Merge conflicts fixed

The build is failing because github is expecting a config file for appveyor. Can you please check if that's the cause or something else that needs to be done

ukanga
ukanga requested changes Mar 30, 2019
View reviewed changes
Copy link
Contributor

@ukanga ukanga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shobhitagarwal1612 we did come to the conclusion of having both AppVeyor and CircleCI in #262. I don't think my reservations has changed on that. The 20 minutes might be a long time but let's hope AppVeyor will support parallel jobs for open source projects.
As such I may consider the CircleCI changes for inclusion without removal of AppVeyor.

@shobhitagarwal1612
Copy link
Contributor Author

I hadn't considered windows platform validation.
I will undo the removal of appveyor and keep the rest of the changes. Thank you !

@shobhitagarwal1612 shobhitagarwal1612 changed the title Remove Appveyor CI/CD Build artifacts on Circle CI Mar 30, 2019
@shobhitagarwal1612
Copy link
Contributor Author

@ukanga Done. Please review

@ukanga ukanga merged commit dbfac0a into XLSForm:master May 5, 2019
@shobhitagarwal1612 shobhitagarwal1612 deleted the remove-appveyor branch May 6, 2019 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ukanga ukanga ukanga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove appveyor and use CircleCI to build artifacts
3 participants
@shobhitagarwal1612 @codecov-io @ukanga