-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build artifacts on Circle CI #284
Conversation
Codecov Report
@@ Coverage Diff @@
## master #284 +/- ##
=======================================
Coverage 81.19% 81.19%
=======================================
Files 23 23
Lines 3106 3106
Branches 729 729
=======================================
Hits 2522 2522
Misses 450 450
Partials 134 134 Continue to review full report at Codecov.
|
@ukanga I can still see the |
2307889
to
f179b0a
Compare
@ukanga Merge conflicts fixed The build is failing because github is expecting a config file for appveyor. Can you please check if that's the cause or something else that needs to be done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shobhitagarwal1612 we did come to the conclusion of having both AppVeyor and CircleCI in #262. I don't think my reservations has changed on that. The 20 minutes might be a long time but let's hope AppVeyor will support parallel jobs for open source projects.
As such I may consider the CircleCI changes for inclusion without removal of AppVeyor.
I hadn't considered windows platform validation. |
f179b0a
to
6ef12ae
Compare
@ukanga Done. Please review |
Closes #283
Screenshot: