Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure parameters are typed properly #267

Merged
merged 1 commit into from
Feb 20, 2019
Merged

Ensure parameters are typed properly #267

merged 1 commit into from
Feb 20, 2019

Conversation

yanokwa
Copy link
Contributor

@yanokwa yanokwa commented Feb 19, 2019

  • Wrap parameters inint() to make the comparisons valid
  • Use large and realistic numbers in the test

@yanokwa yanokwa requested a review from ukanga February 19, 2019 22:21
@yanokwa
Copy link
Contributor Author

yanokwa commented Feb 19, 2019

Sorry about letting this one slip through, @ukanga. I'd appreciate hot fix!

@ukanga ukanga merged commit 1625712 into XLSForm:master Feb 20, 2019
@yanokwa yanokwa deleted the fix-int branch March 8, 2019 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ukanga ukanga ukanga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yanokwa @ukanga