Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple improvements: diarization, timestamps, Dockerfile, dependencies... #31

Merged
merged 21 commits into from
May 5, 2023
Merged

Multiple improvements: diarization, timestamps, Dockerfile, dependencies... #31

merged 21 commits into from
May 5, 2023

Conversation

chainyo
Copy link
Contributor

@chainyo chainyo commented May 2, 2023 •
edited
Loading

  • Replace diarization with NVIDIA NeMo asr toolkit
  • Update config.py and add validators for necessary config settings
  • Update the Docker image with the latest from NVIDIA
  • Fix dependencies and versions
  • Fix Python version to 3.9 locally and on Docker
  • New available timestamps format: ms. Now user can choose between hms, s (default) and ms.
  • Remove unused num_speakers parameter.

@chainyo chainyo added the enhancement New feature or request label May 2, 2023
@chainyo chainyo self-assigned this May 2, 2023
@chainyo chainyo linked an issue May 2, 2023 that may be closed by this pull request
Diarization should be improved for audio with >2 speakers #12
Closed
@chainyo
Copy link
Contributor Author

chainyo commented May 3, 2023 •
edited
Loading

Close #20 #21 #24 #28

@chainyo chainyo changed the title 12 diarization should be improved for audio with 2 speakers Multiple improvements: diarization, timestamps, Dockerfile, dependencies... May 5, 2023
@chainyo chainyo merged commit 1e4295e into main May 5, 2023
@chainyo chainyo deleted the 12-diarization-should-be-improved-for-audio-with-2-speakers branch May 5, 2023 10:39
@chainyo chainyo mentioned this pull request May 5, 2023
Closed
This was referenced May 5, 2023
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleksandr-smechov aleksandr-smechov aleksandr-smechov approved these changes

Assignees

@chainyo chainyo

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Diarization should be improved for audio with >2 speakers
2 participants
@chainyo @aleksandr-smechov