Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let faster-whisper handle model path #251

Merged
merged 3 commits into from
Sep 23, 2023
Merged

Let faster-whisper handle model path #251

merged 3 commits into from
Sep 23, 2023

Conversation

chainyo
Copy link
Contributor

@chainyo chainyo commented Sep 18, 2023 •
edited
Loading

This PR removes the config validator for the whisper_model and lets faster-whisper handle the model path.

This way we can use custom public/private ctranslate2 models hosted on HF hub.

@chainyo chainyo added api Everything related to the API implementation transcription Everything related to the transcription part labels Sep 18, 2023
@chainyo chainyo linked an issue Sep 18, 2023 that may be closed by this pull request
Allow custom ctranslate2 whisper models from HF hub #250
Closed
@chainyo
Copy link
Contributor Author

chainyo commented Sep 23, 2023

Hi @aleksandr-smechov this is ready to go.

@chainyo chainyo merged commit dfce3fc into main Sep 23, 2023
2 checks passed
@chainyo chainyo deleted the 250-allow-custom-ctranslate2-whisper-models-from-hf-hub branch September 23, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleksandr-smechov aleksandr-smechov aleksandr-smechov approved these changes

Assignees
No one assigned
Labels
api Everything related to the API implementation transcription Everything related to the transcription part
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow custom ctranslate2 whisper models from HF hub
2 participants
@chainyo @aleksandr-smechov