Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add offset audio transcription #237

Merged
merged 1 commit into from
Sep 4, 2023
Merged

Add offset audio transcription #237

merged 1 commit into from
Sep 4, 2023

Conversation

chainyo
Copy link
Contributor

@chainyo chainyo commented Sep 4, 2023

This PR:

  • Added offset_start and offset_end parameters to choose when to start and end the transcription
  • Added the offset_start to post-processing step
  • Removed unused conversion functions (old ms to format functions)
  • Fixed the hms formatting, which was not displaying milliseconds correctly
  • Fixed the Utterance model to handle strings for start and end keys (hms requirement)

@chainyo chainyo added bug Something isn't working api Everything related to the API implementation labels Sep 4, 2023
@chainyo chainyo linked an issue Sep 4, 2023 that may be closed by this pull request
@chainyo
Copy link
Contributor Author

chainyo commented Sep 4, 2023

I'm not sure why the Quality tests are failing atm:

Error: Can't use 'tar -xzf' extract archive file: /home/runner/work/_actions/_temp_aca62ba8-e0c6-417a-8163-11bee7ca931b/19e56154-68cd-4a99-acb9-612117537355.tar.gz. return code: 2.

It's not related to the test results. Are we limited by GitHub Actions?

@chainyo chainyo merged commit 4f639cd into main Sep 4, 2023
1 of 2 checks passed
@chainyo chainyo deleted the 221-control-over-audio branch September 4, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Everything related to the API implementation bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Control over audio
2 participants