Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split NeMo diarization process into sub-modules #180

Merged
merged 26 commits into from
Aug 1, 2023
Merged

Split NeMo diarization process into sub-modules #180

merged 26 commits into from
Aug 1, 2023

Conversation

chainyo
Copy link
Contributor

@chainyo chainyo commented Aug 1, 2023 •
edited
Loading

This PR:

  • Remove NeMo NeuralDiarizer pipeline
  • Add independant diarization modules to make diarization more modular and efficient
  • Remove NeMo config files
  • Remove the config folder step to Dockerfile

@chainyo chainyo added api Everything related to the API implementation diarization Everything related to the diarization part labels Aug 1, 2023
@chainyo chainyo self-assigned this Aug 1, 2023
@chainyo chainyo linked an issue Aug 1, 2023 that may be closed by this pull request
Check how to split Nvidia NeMo diarization service into multiple sub-services #166
Closed
@chainyo chainyo merged commit 7f398a2 into main Aug 1, 2023
3 checks passed
@chainyo chainyo deleted the 166-check-how-to-split-nvidia-nemo-diarization-service-into-multiple-sub-services branch August 1, 2023 17:41
@chainyo chainyo mentioned this pull request Aug 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleksandr-smechov aleksandr-smechov aleksandr-smechov approved these changes

Assignees

@chainyo chainyo

Labels
api Everything related to the API implementation diarization Everything related to the diarization part
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check how to split Nvidia NeMo diarization service into multiple sub-services
2 participants
@chainyo @aleksandr-smechov