-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the @
silencing warnings from PL
#709
Comments
@mukeshpanchal27 @joemcgill One thing I'd like to highlight here for context is that all of the
|
Thanks for the context, @felixarntz. I know that WP Core has gone through a lengthy process of identifying and removing error silencing from a bunch of places in the past few years, so it would be interesting to know if these were not updated in It looks like there are currently [14 instances of Regardless, I don't see this as I high priority issue for us to address. More of a nice maintenance cleanup. |
As we removed the module infrastucture we no longer needs to check for PL plugin codebase as we remove those code now.
@pbearne Could you tell us which error you want to by pass here? As we are set min 7.2 now can we remove that PHPCS comment? |
Bug Description
Followup for #695
As @joemcgill suggested in other conversation we have to remove
@
silencing warnings from all files.cc. @felixarntz
The text was updated successfully, but these errors were encountered: