Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for each module to only load it if the corresponding standalone plugin is not loaded #666

Closed
Tracked by #656
felixarntz opened this issue Mar 10, 2023 · 1 comment · Fixed by #670
Closed
Tracked by #656
Assignees
Labels
Infrastructure Issues for the overall performance plugin infrastructure [Plugin] Performance Lab Issue relates to work in the Performance Lab Plugin only [Type] Enhancement A suggestion for improvement of an existing feature

Comments

@felixarntz
Copy link
Member

felixarntz commented Mar 10, 2023

Feature Description

As part of #656, a temporary state between completion of Milestone 1 and Milestone 2 will be that certain features will exist both as a Performance Lab module and as a standalone plugin. We should make sure there are no conflicts. Specifically, we can ensure that, if a certain standalone plugin is active, we don't load or allow enabling the corresponding Performance Lab module.

Requirements

  • The function that loads the active modules should for each module check whether it also exists as a standalone plugin and whether that standalone plugin is active. If yes, the respective module should not be loaded.
  • The same check should happen on the Performance Lab admin screen. Any module where the standalone plugin is active should as disabled and with a message similar to when it cannot be loaded for another reason: The module cannot be managed with Performance Lab since it is already active as a standalone plugin.
@mukeshpanchal27
Copy link
Member

Closed this as completed in #670

@felixarntz felixarntz added the [Plugin] Performance Lab Issue relates to work in the Performance Lab Plugin only label Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Issues for the overall performance plugin infrastructure [Plugin] Performance Lab Issue relates to work in the Performance Lab Plugin only [Type] Enhancement A suggestion for improvement of an existing feature
Projects
None yet
2 participants